Ticket #537 (closed enhancement: fixed)
Opened 2011-05-23T11:52:08-05:00
Last modified 2012-08-14T11:55:37-05:00
Update ROIs correctly in DatasetHarmonizer
| Reported by: | curtis | Owned by: | bdezonia |
|---|---|---|---|
| Priority: | major | Milestone: |
|
| Component: | Legacy Compatibility | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #1011 |
Description
The legacy layer needs to translate ROIs back and forth between IJ1 and IJ2. This will allow legacy plugins to generate and/or manipulate ROIs.
Change History
comment:1 Changed 2011-05-27T15:51:36-05:00 by curtis
comment:2 Changed 2011-06-06T12:42:26-05:00 by curtis
- Owner changed from curtis to leek
- Status changed from new to assigned
comment:3 Changed 2011-06-09T12:57:55-05:00 by leek
Binary mask overlays work. Any ROI that's unhandled becomes a binary mask overlay by default.
comment:4 Changed 2011-06-21T08:21:33-05:00 by leek
- Status changed from assigned to accepted
I added a check in setDatasetOverlays to see if the legacy code changed the ImagePlus selection:
- Create a ROI from the dataset's overlays
- Harvest its path
- Harvest the path of the ImagePlus ROI
- Compare
- Do nothing if the two paths are identical
It seems to work well.
To do at this point:
- do whatever is necessary to harmonize a ROI drawn on a legacy stack with the proper slice in ImageJ 2.0
- Erase current overlays at the current stack position if the paths are not identical.
comment:5 Changed 2011-06-21T10:01:14-05:00 by leek
I now set the slice information (the plane) when converting ROIs to overlays and erase overlays when the legacy ROI has been modified.
comment:6 Changed 2011-07-26T10:24:53-05:00 by leek
- Milestone changed from biweekly-2011: Jul-18 to Jul-29 to imagej-2.0-beta1
comment:7 Changed 2011-07-27T15:12:47-05:00 by curtis
- Milestone changed from imagej-2.0-beta1 to imagej-2.0-alpha5
comment:8 Changed 2011-09-12T10:58:48-05:00 by leek
- Milestone changed from imagej-2.0-alpha5 to imagej-2.0-beta3
comment:10 Changed 2012-08-14T11:08:36-05:00 by curtis
- Owner changed from leek to bdezonia
- Status changed from accepted to assigned
- Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta6
What still remains to be done for this ticket?
comment:11 Changed 2012-08-14T11:55:37-05:00 by bdezonia
- Status changed from assigned to closed
- Resolution set to fixed
- Milestone changed from imagej-2.0.0-beta6 to imagej-2.0.0-beta4
All remaining issues are in ticket #1308. Closing this ticket.
Progress: d1b8f41fba2b8e73256e4302d7e554f35201529d, b209d1da7d33e6026b6095906bd86dc08eab3780, 7b8296b3e782d502093a2dd9e440de025d8e04a0, d639e451c8b2659888ff36a68ad031b4d76911ea, 9b3734525eb6c145fc6dc9157d1c43694e76c816.
Substantial work still remains.