Ticket #1216 (closed defect: moved)
Opened 2012-06-13T14:07:33-05:00
Last modified 2012-09-10T10:22:35-05:00
DefaultDatasetView::autoscale() is inefficient and broken
| Reported by: | bdezonia | Owned by: | curtis |
|---|---|---|---|
| Priority: | major | Milestone: | imagej-2.0.0 |
| Component: | Display API | Version: | |
| Severity: | serious | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #1170 |
Description
From a debugging session I see that sequential calls to DefaultDatasetView::autoscale() end up repeatedly computing the overall min and max. It could compute once and use cached results. Also it uses overall min and max rather than channel min and max which may be broken. Note too that Curtis has a TODO item listed saying autoscale() is wrong. We should revisit autoscaling.
Change History
comment:2 Changed 2012-08-14T12:27:58-05:00 by bdezonia
- Status changed from new to assigned
- Milestone changed from imagej-2.0.0-beta4 to imagej-2.0.0-beta6
comment:3 Changed 2012-08-14T12:28:14-05:00 by bdezonia
- Milestone changed from imagej-2.0.0-beta6 to imagej-2.0.0
comment:4 Changed 2012-09-10T10:22:35-05:00 by bdezonia
Note at some point I added code to make sure autoscale() calcs min and max by channel correctly now.
comment:5 Changed 2014-12-18T12:52:55-06:00 by curtis
- Status changed from assigned to closed
- Resolution set to moved