[ImageJ-devel] CroppedIterableInterval

[Brian Northan]

Hi Christian

Thanks and feel free to re-use the test case.

I've seen that Imglib2 uses the name "hyperslice" when retrieving a
subsection.  So maybe something like "HyperSliceIterator"??  Or
SliceWiseIterator to fit in with the naming of the slicemapper?


On Fri, Jun 13, 2014 at 3:06 AM, Christian Dietz <
christian.dietz at uni-konstanz.de> wrote:

>  Hi Brian,
>
> you are absolutely right, this is a bug. I fixed the bug and added your
> test-case to our CroppedIterableIntervalTest class (I hope that's OK?!).
>
> Thank you for reporting the bug!
>
> Christian
>
> PS: I don't really like the name "CroppedIterableInterval", as we don't
> really crop something. Any suggestions?
>
>
>
> On 12.06.2014 21:45, Brian Northan wrote:
>
>   Hi List
>
> I was trying to figure out how the CroppedIterableInterval in imagej-ops
> works.
>
>  My understanding is that the "axesOfInterest" array defines the axes of
> the resulting "cropped hypeslices".  So if you have x as axis 0, y:1, c:2,
> z:3 and t:4 and you specify 0 (x),  1 (y), and 3 (z) as the
> "axesOfInterest" it should loop through c and t and return x,y,z
> hyperslices?  Is that correct??
>
>  If I am correct in my assumption of how it works I noticed one thing
> that is possibly a bug (if I misunderstood how it is supposed to work
> disregard the rest of this e-mail).
>
> Around line 100
>
>  *if (axesOfInterest[j] == i) { dimensionsToIterate[ ** j ** ] = 1;*
>
>  should maybe be
>
>  *dimensionsToIterate[ ** i **]=1;*
>
>  I have a test that only works if I change the above line of code in a
> local copy of CroppedIterableInterval.java
>
> The test is here:
> https://github.com/DeconWaRE/deconware-ops/blob/master/src/test/java/com/deconware/ops/SlicerTest.java
>
>  Brian
>
>
>
> _______________________________________________
> ImageJ-devel mailing listImageJ-devel at imagej.nethttp://imagej.net/mailman/listinfo/imagej-devel
>
>
>
> _______________________________________________
> ImageJ-devel mailing list
> ImageJ-devel at imagej.net
> http://imagej.net/mailman/listinfo/imagej-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://imagej.net/pipermail/imagej-devel/attachments/20140613/b80f9ccd/attachment.html>