<div dir="ltr"><div>Hi Christian<br><br></div><div>Thanks and feel free to re-use the test case.  <br><br>I've seen that Imglib2 uses the name "hyperslice" when retrieving a subsection.  So maybe something like "HyperSliceIterator"??  Or SliceWiseIterator to fit in with the naming of the slicemapper?<br>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 13, 2014 at 3:06 AM, Christian Dietz <span dir="ltr"><<a href="mailto:christian.dietz@uni-konstanz.de" target="_blank">christian.dietz@uni-konstanz.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    <div>Hi Brian,<br>
      <br>
      you are absolutely right, this is a bug. I fixed the bug and added
      your test-case to our CroppedIterableIntervalTest class (I hope
      that's OK?!).<br>
      <br>
      Thank you for reporting the bug!<br>
      <br>
      Christian<br>
      <br>
      PS: I don't really like the name "CroppedIterableInterval", as we
      don't really crop something. Any suggestions?<div><div class="h5"><br>
      <br>
      <br>
      On 12.06.2014 21:45, Brian Northan wrote:<br>
    </div></div></div>
    <blockquote type="cite"><div><div class="h5">
      <div dir="ltr">
        <div>
          <div>
            <div>Hi List<br>
              <br>
              I was trying to figure out how the CroppedIterableInterval
              in imagej-ops works.  <br>
              <br>
            </div>
            My understanding is that the "axesOfInterest" array defines
            the axes of the resulting "cropped hypeslices".  So if you
            have x as axis 0, y:1, c:2, z:3 and t:4 and you specify 0
            (x),  1 (y), and 3 (z) as the "axesOfInterest" it should
            loop through c and t and return x,y,z hyperslices?  Is that
            correct??<br>
            <br>
          </div>
          <div>If I am correct in my assumption of how it works I
            noticed one thing that is possibly a bug (if I misunderstood
            how it is supposed to work disregard the rest of this
            e-mail). <br>
          </div>
          <br>
          Around line 100<br>
        </div>
        <div>
          <div> <span><br>
            </span>
            <div style="margin-left:40px"><i><span>if</span> <span>(</span><span>axesOfInterest</span><span>[</span><span>j</span><span>]</span>
                <span>==</span> <span>i</span><span>)</span> <span>{</span> <span>dimensionsToIterate</span><span>[</span><span> ** j ** </span><span>]</span> <span>=</span> <span>1</span><span>;</span></i><br>
            </div>
            <div style="margin-left:40px"><span></span></div>
          </div>
          <div><span><br>
            </span></div>
          <div><span>should maybe be <br>
              <br>
            </span>
            <div style="margin-left:40px">
              <i><span>dimensionsToIterate[ ** i **]=1;</span></i><br>
            </div>
            <div style="margin-left:40px"><span></span></div>
          </div>
          <pre><span>
</span></pre>
          <span>I have a test that only works if I change the
            above line of code in a local copy of
            CroppedIterableInterval.java<br>
            <br>
            The test is here: <a href="https://github.com/DeconWaRE/deconware-ops/blob/master/src/test/java/com/deconware/ops/SlicerTest.java" target="_blank">https://github.com/DeconWaRE/deconware-ops/blob/master/src/test/java/com/deconware/ops/SlicerTest.java</a>
            <br>
          </span>
          <div>
            <div><br>
            </div>
            <div>Brian<br>
            </div>
            <div><br>
            </div>
          </div>
        </div>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      </div></div><pre>_______________________________________________
ImageJ-devel mailing list
<a href="mailto:ImageJ-devel@imagej.net" target="_blank">ImageJ-devel@imagej.net</a>
<a href="http://imagej.net/mailman/listinfo/imagej-devel" target="_blank">http://imagej.net/mailman/listinfo/imagej-devel</a>
</pre>
    </blockquote>
    <br>
  </div>

<br>_______________________________________________<br>
ImageJ-devel mailing list<br>
<a href="mailto:ImageJ-devel@imagej.net">ImageJ-devel@imagej.net</a><br>
<a href="http://imagej.net/mailman/listinfo/imagej-devel" target="_blank">http://imagej.net/mailman/listinfo/imagej-devel</a><br>
<br></blockquote></div><br></div>