[ImageJ-devel] Labeling - Revised Branch

[Tobias Pietzsch]

Hi Martin and Christian,


I looked a bit at the source, but I'm not sure I get it all yet.


Probably it's a good thing, that Labeling is not an Img anymore.
For views etc. you will use it as a RandomAccessible<LabelingType<?>>,
so you will lose the additional stuff provided by the Labeling anyway.
So not much change there.

Why not go one step further and not store the NativeImgLabeling in a
RandomAccessibleInterval<? extends IntegerType<?>> instead of an
Img<? extends IntegerType<?>>?


The main point for you is, that now you can use "smaller" IntegerTypes
(eg. Byte) to store the Labeling, so you save memory, right?

That's cool, but it comes with the additional overhead of using a
SamplerConverter for the Accessors. So you trade of memory vs 
computation time. Did you do any benchmarks to see how much
runtime-overhead you have there?


best regards,
Tobias


On 03/19/2012 10:05 PM, Christian Dietz wrote:
> Hi Tobi & Lee,
>
> I created a new branch with some changes of Martin Horn and me
> concerning the Labeling (labeling-revised).
> Actually the we changed only a little.
>
> The main differences are:
>
> - Generic Labeling of any IntegerType (Bit, Byte, Short, Int and so on)
>
> - Labeling is not an Img<LabelingType<?>> anymore, but still
> IterableInterval<LabelingType<?>> and RandomAccessible<LabelingType<?>>
>
> - The Labeling is created a little different now (Img<? extends
> IntegerType<?>> is provided in the constructor as the storage).
>
> Please see this as some suggestions from our side and we are pretty sure
> it's not perfect or even good ;) But maybe it's a good starting point
> for some future discussions.
>
> Thank you for your comments in advance,
>
>
> Martin & Christian :)
>