Hi Steffi,<br><br>Thanks for the explanation, and sorry for the delay in reply; I have been on family leave for the past two weeks.<div><br></div><div>I really like your solution. In certain cases, I think raw types are the only way to get around the awkwardness of the recursive typing approach.<br>
<br>I tested the newimgopener branch with ImageJ2, and it works. My vote is to merge to master.<br><br>Regards,<div>Curtis</div><div><br><br><div class="gmail_quote">On Tue, Jul 17, 2012 at 4:08 PM, Stephan Preibisch <span dir="ltr"><<a href="mailto:preibisch@mpi-cbg.de" target="_blank">preibisch@mpi-cbg.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi guys,<br>
<br>
this became a massive explanation. I suggest this as as solution to a problem we have been only partly aware of. I hope you enjoy reading ;)<br>
<br>
Steffi<br>
<br>
<br>
As the ImageJ conference is approaching I was talking with Johannes and we agreed that the ImgOpener needs to be finished. However, since its first version there has been a major design fault.<br>
<br>
But first the good news:<br>
--------------------------------<br>
It works perfectly fine if you say "open me an Image as float" or "...as UnsignedByte" or whatever, classically called by the method<br>
-> new ImgOpener.openImg( String id, ImgFactory<T> factory, T type );<br>
It can, without any problems, return you an Img<T>, and it requires that T is RealType (and not anymore NativeType, see at the end). So far, so good.<br>
Note that "T" is NOT a return parameter, but something you give to the openAs method.<br>
<br>
Now the bad news.<br>
--------------------------<br>
If you say "open this image as whatever RealType it is", it can do that, but it cannot assign a "T" to it - because T is not a return parameter. We made an ugly hack inside so that it seems as if it would work, but it does not. Now you might ask, why change it if it worked so far? Well, here is an easy example that would cause a ClassCastException on run time<br>
<br>
public static <T extends RealType< T >> void main( String[] args )<br>
{<br>
Img< T > img1 = new ImgOpener.openImg( "somepic_8bit.tif" ); // 8-bit unsigned<br>
Img< T > img2 = new ImgOpener.openImg( "somepic_32bit.tif" ); // 32-bit float<br>
<br>
img1.firstElement().set( img2.firstElement() ); // run-time crash<br>
}<br>
<br>
It will throw a ClassCastException because img1 is of UnsignedByteType and img2 of FloatType. But as we cast it in a dirty way, it compiles just fine.<br>
So, we cannot return a "T", but what we can return is Img< which is at least a RealType >. And this is for sure always true, but img1 and img2 are not necessarily the same RealType (as above).<br>
<br>
The correct way (which doesn't work)<br>
--------------------------------------------------<br>
What we should return is an Img< ? extends RealType< ? > >. However, it is not ensured that the two "?" are the same, so an Img of this type is basically incompatible with everything else, which means an unchecked cast is necessary. So although correct, maybe not a good idea. And it is really ugly to write if necessary.<br>
<br>
The still somehow correct way<br>
-----------------------------------------<br>
Instead, it returns now an Img< RealType >. This is kind of a tradeoff. On one hand, this is very easy to write and will give you compile errors where it should, for example<br>
<br>
img1.firstElement().set( img2.firstElement() ); // COMPILE ERROR (not the same RealType realization)<br>
<br>
OR<br>
<br>
public <T extends RealType< T >> void add( IterableInterval< T > i1, IterableInterval< T > i2 ) { .... }<br>
add( img1, img2 ); // COMPILE ERROR (not the same RealType realization)<br>
<br>
BUT<br>
<br>
Gauss.inFloatInPlace( 2.0 , img1 ); // FINE (just one RealType realization required, inside it will be always the same "T")<br>
Gauss.inFloatInPlace( 2.0 , img2 ); // FINE (just one RealType realization required, inside it will be always the same "T")<br>
<br>
public < T extends RealType< T > > void add1( Img< T > img1, double value ) { ... }<br>
add1( img1, 5 ); // FINE (just one RealType realization required, inside it will be always the same "T")<br>
<br>
public < T extends RealType< T >, S extends RealType< S > > void add2( Img< T > img1, Img< S > img2 ) { ... }<br>
add2( img1, img2 ); // FINE (explicitly two different RealType realizations are allowed)<br>
<br>
public void add3( Img< RealType > img1, Img< RealType > img2 ) { ... }<br>
add3( img1, img2 ); // FINE (both are just some kind of RealType, but gives a warning)<br>
<br>
On the other hand it gives a lot of Warnings because RealType should be more specified.<br>
<br>
Why not Img< RealType< ? > ><br>
------------------------------------------<br>
Similar problem as in <? extends RealType< ? > >. RealType< ? > is not a valid substitute for any construct like < T extends RealType < T > >. One would have to cast to Img< RealType >, so we can take this one right away as it is less writing.<br>
<br>
Where did NativeType go?<br>
------------------------------------<br>
I do not see any reason why we should enforce a NativeType. There is no objection to load an image into a (hypothetical) ListImg< BigDecimalType >.<br>
<br>
What are the implications?<br>
-----------------------------------<br>
We should write NOTHING except the method opening files for Img< RealType >. And also only if it is really required - quite often it is not. But if, Img< RealType > It is a completely valid input for any generic algorithm as show above for Gauss, add, etc.<br>
<br>
<br>
<br>
I implemented the changes on a branch called 'newimgopener'. It also contains four static convenience opening methods and a speed improvement.<br>
<br>
Any comments are very welcome. If somebody has a better idea how to solve the problem ... I am all ears ...<br>
<br>
Bye bye,<br>
Steffi<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Please avoid top-posting, and please make sure to reply-to-all!<br>
<br>
Mailing list web interface: <a href="http://groups.google.com/group/fiji-devel" target="_blank">http://groups.google.com/group/fiji-devel</a><br>
</font></span></blockquote></div><br></div></div>