<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">In principle, I agree. However it might break some code in a bad way. We used several times constructs like<div><br></div><div>Img< T > img;</div><div><br></div><div>if ( img instanceOf ImagePlusImg )</div><div>{</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>// get the underlying instance (which is especially true after wrapping)</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>ImagePlus imp = ((ImagePlusImg)img).getImagePlus();</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>....</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>// or do something else where you test instanceof</div><div>}<br><div><br></div><div>which would suddenly fail because ImgPlus is an Img, but only HAS for example an ImagePlusImg...</div><div><br></div><div>What do you think?</div><div><br></div><div>Bye bye,</div><div>Steffi</div><div><br></div><div><br><div><div>On Jul 12, 2012, at 16:33 , Curtis Rueden wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi Steffi,<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>you could just add another wrap method that does that if you like ... seems useful to me . ...</blockquote>
<div><div><br></div><div>I agree with J-Y: the wrap methods could always return ImgPlus, since an ImgPlus is also an Img. No reduction in functionality there.</div><div><br></div><div>-Curtis</div><div><br></div><br><div class="gmail_quote">
On Thu, Jul 12, 2012 at 3:30 PM, Stephan Preibisch <span dir="ltr"><<a href="mailto:preibisch@mpi-cbg.de" target="_blank">preibisch@mpi-cbg.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Hi J-Y,<div><br></div><div>you could just add another wrap method that does that if you like ... seems useful to me . ...</div><div><br></div><div>Bye bye,</div><div>Steffi</div><div><div class="h5">
<div><br><div><div>On Jul 12, 2012, at 16:28 , Jean-Yves Tinevez wrote:</div><br><blockquote type="cite">
<div bgcolor="#FFFFFF" text="#000000">
<br>
<blockquote type="cite">
<div>
<div>
<div>
<blockquote type="cite">
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
</blockquote>
<div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I
would like to add the following methods to
CalibratedSapce.java</blockquote>
<div><br>
</div>
<div>I think these methods are good additions!</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
</blockquote>
<div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style=""><span style="white-space:pre-wrap"> </span></span>/**
Sets the image calibration for the given dimension.
*/<br>
<span style="white-space:pre-wrap"> </span><span style="color:rgb(127,42,103)">void</span> setCalibration(<span style="color:rgb(127,42,103)">double</span>[]
cal);<br>
<span style=""><span style="white-space:pre-wrap"> </span></span>/**
Sets the image calibration for the given dimension.
*/<br>
<span style="white-space:pre-wrap"> </span><span style="color:rgb(127,42,103)">void</span> setCalibration(<span style="color:rgb(127,42,103)">float</span>[] cal);</blockquote>
</div>
</div>
<div><br>
</div>
<div>Shouldn't the javadoc for these read "Sets the image
calibration from the given array." or similar?</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
<br>
Hi all<br>
<br>
Any chance ImagePlusAdapter wrap() methods return an ImgPlus?<br>
<br>
Cheers<br>
jy<br>
</div>
</blockquote></div><br></div></div></div></div><div class="HOEnZb"><div class="h5"><div><br class="webkit-block-placeholder"></div>
-- <br>
Please avoid top-posting, and please make sure to reply-to-all!<br>
<br>
Mailing list web interface: <a href="http://groups.google.com/group/fiji-devel" target="_blank">http://groups.google.com/group/fiji-devel</a><br>
</div></div></blockquote></div><br></div><div><br class="webkit-block-placeholder"></div>
-- <br>
Please avoid top-posting, and please make sure to reply-to-all!<br>
<br>
Mailing list web interface: <a href="http://groups.google.com/group/fiji-devel">http://groups.google.com/group/fiji-devel</a><br>
</blockquote></div><br></div></div></body></html>