Hi Albert, Tobias and everyone,<br><br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">> I.e., Histogram should not have an getHistogram()<br>
> that returns an int[] array which represents the histogram. Rather,<br>
> Histogram itself should represent the histogram. For example, it could<br>
> implement RandomAccessibleInterval< IntType > to achieve that, and the<br>
> histogram could be computed in the constructor.<br><br>I agree with that. The scripting library follows this approach to the<br>
fullest. Functions on images are images themselves.<br></blockquote>
<br>I also think this is a good idea. However, we don't currently have time to make these changes. So for now I split the imglib2-algorithms package as discussed. This allowed us to fix the ImageJ2 build.<br><br>I have filed a ticket to remind us about the proposed Histogram changes:<br>
<a href="http://code.imagej.net/trac/imagej/ticket/1041">http://code.imagej.net/trac/imagej/ticket/1041</a><br><span class="HOEnZb"><font color="#888888"></font></span><br>Tobias, you are CCed. Anyone else interested let me know and I will add you to the CC list.<br>
<br>Regards,<br>Curtis<br><br><br><div class="gmail_quote">On Thu, Mar 1, 2012 at 4:46 AM, Albert Cardona <span dir="ltr"><<a href="mailto:sapristi@gmail.com">sapristi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
El 1 de març de 2012 5:39, Tobias Pietzsch <<a href="mailto:pietzsch@mpi-cbg.de">pietzsch@mpi-cbg.de</a>> ha escrit:<br>
<div class="im">> Hi all,<br>
><br>
><br>
> On 02/29/2012 09:30 PM, Curtis Rueden wrote:<br>
>><br>
>> 2) Split imglib2-algorithms into multiple components:<br>
>> imglib2-algorithms-bsd and imglib2-algorithms-gpl, for example. Then we<br>
>> can include imglib2-algorithms-bsd as a dependency for ImageJ2.<br>
><br>
><br>
> This is the option I would prefer.<br>
> If you could do the split, Curtis, that would be great.<br>
><br>
> I do not think that the definition for "core" should be "everything<br>
> needed by ImageJ2". I don't see a problem with splitting ImageJ2<br>
> dependencies.<br>
<br>
</div>That is sensible.<br>
<div class="im"><br>
> I don't have a problem with having Histogram in the core, either.<br>
> But then it should not implement the Algorithm interface (I don't<br>
> get the point of the Algorithm interface, to be honest). Equally<br>
> important: it should not _feel_ like an algorithm, rather it should<br>
> _be_ the histogram. I.e., Histogram should not have an getHistogram()<br>
> that returns an int[] array which represents the histogram. Rather,<br>
> Histogram itself should represent the histogram. For example, it could<br>
> implement RandomAccessibleInterval< IntType > to achieve that, and the<br>
> histogram could be computed in the constructor.<br>
<br>
</div>I agree with that. The scripting library follows this approach to the<br>
fullest. Functions on images are images themselves.<br>
<span class="HOEnZb"><font color="#888888"><br>
Albert<br>
<br>
--<br>
<a href="http://albert.rierol.net" target="_blank">http://albert.rierol.net</a><br>
<a href="http://www.ini.uzh.ch/%7Eacardona/" target="_blank">http://www.ini.uzh.ch/~acardona/</a><br>
</font></span></blockquote></div><br>