Hi Johannes,<br><br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">I'd like to change the priorities so that the higher the number, the greater the priority.<br>
</blockquote><br>Sounds good. We'll just have to invert the compareTo method in the AbstractUIDetails class. (All modules and tools are sorted that way.)<br><br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
I am thinking about imagej.util.Priorities.<br></blockquote><br>Maybe imagej.util.Priority, to match some of the enums like WidgetStyle and ItemVisibility? (Though admittedly, the Priority class wouldn't be an enum...)<br>
<br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
Then I'd like to introduce a SortByPriority helper class that takes an<br>
Iterator<T> as parameter to the constructor and a helper class that<br>
determines a priority (type "double") given an instance of T. The<br>
SortByPriority class then presents itself as an Iterable<T> and outputs<br>
the items in order of the priority.<br></blockquote><br>I was going to say it seemed a bit on the YAGNI side, but we would benefit from a way to sort IPluginFinders without complicating the interface. However, I don't understand how that second helper class would determine a priority from the instance of T. Maybe T must extend a Prioritized interface with a getPriority method—but that would require IPluginFinder to implement it, hence complicating the interface. Perhaps your proposed patch to PluginService is good enough?<br>
<br>Regards,<br>Curtis<br><br><br><div class="gmail_quote">
On Wed, Nov 30, 2011 at 5:13 PM, Johannes Schindelin <span dir="ltr"><<a href="mailto:schindelin@wisc.edu" target="_blank">schindelin@wisc.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
I see that the top priority in imagej.ext.plugin.Plugin is defined as<br>
negative infinity. That's a bit counter-intuitive to me. I'd like to<br>
change the priorities so that the higher the number, the greater the<br>
priority.<br>
<br>
Then I'd like to define a new class which has constants for these<br>
priorities. I am thinking about imagej.util.Priorities.<br>
<br>
Then I'd like to introduce a SortByPriority helper class that takes an<br>
Iterator<T> as parameter to the constructor and a helper class that<br>
determines a priority (type "double") given an instance of T. The<br>
SortByPriority class then presents itself as an Iterable<T> and outputs<br>
the items in order of the priority.<br>
<br>
Objections?<br>
<br>
Ciao,<br>
Johannes<br>
<br>
_______________________________________________<br>
ImageJ-devel mailing list<br>
<a href="mailto:ImageJ-devel@imagejdev.org" target="_blank">ImageJ-devel@imagejdev.org</a><br>
<a href="http://imagejdev.org/mailman/listinfo/imagej-devel" target="_blank">http://imagejdev.org/mailman/listinfo/imagej-devel</a><br>
</blockquote></div><br>