<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Close to the same mistake is replicated in AbstractSwingUI (it
probably works, but the cast is dangerous). The code that references
SwingDisplayWindow in SwingDisplayPanel was added by me today and
should be removed by Grant. If DisplayWindow has a close() method,
then you can add a getWindow() method to DisplayPanel so you can get
the DisplayWindow in a uniform fashion and close it.<br>
<br>
IMHO SwingDisplayWindow should be abstract and you should derive SDI
and MDI versions in the respective packages.<br>
<br>
On 9/6/2011 12:34 PM, Curtis Rueden wrote:
<blockquote
cite="mid:CADN69ynaMLs+GhR8F1vHjzu2hWPwueCK+QgPh1VxiGNMcu59cg@mail.gmail.com"
type="cite">Hi Grant,<br>
<br>
<blockquote style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px
solid rgb(204, 204, 204); padding-left: 1ex;"
class="gmail_quote">And SwingDisplayWindow should actually be in
the Swing-SDI package.<br>
</blockquote>
<br>
Just a heads up: SwingDisplayWindow is referenced in
AbstractSwingUI as well as SwingDisplayPanel, both of which are in
the ij-ui-swing-base package. It looks like it would be
non-trivial to migrate that class into the ij-ui-swing-sdi
project.<br>
<br>
-Curtis<br>
<br>
<div class="gmail_quote">On Tue, Sep 6, 2011 at 10:30 AM, Grant B.
Harris <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:gharris@mbl.edu">gharris@mbl.edu</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div bgcolor="#FFFFFF" text="#000000"> Lee --<br>
<br>
You have caught an oversight on my part... DisplayWindow
should have a close() method.<br>
And SwingDisplayWindow should actually be in the Swing-SDI
package.<br>
<br>
So, I added a close() method to DisplayWindow and
implemented it in the SDI and MDI packages.<br>
<br>
Let me know if this doesn't take care of the problem.<br>
<pre cols="72">Grant B. Harris
---------------------------------------------------------
Scientific Informatics Analyst, Cellular Dynamics Program
Marine Biological Laboratory, Woods Hole, Mass. 02543
<a moz-do-not-send="true" href="mailto:gharris@mbl.edu" target="_blank">gharris@mbl.edu</a>
</pre>
<div>
<div class="h5"> <br>
On 9/6/2011 10:00 AM, Lee Kamentsky wrote: </div>
</div>
<blockquote type="cite">
<div>
<div class="h5"> Hi Curtis / ImageJ dev. I've gotten
CellProfiler to run ImageJ 2 plugins with images. I
assume that any Display parameter contains an image
with possible overlay and that input Display
parameters will be modified by the time they are
output. The picture below is the result of running one
of the IJ2 shadow commands in CellProfiler.<br>
<br>
I have to fix what looks like a bug in
SwingDisplayPanel. In "close", it assumes that its
direct parent is the SwingDisplayWindow and apparently
that's no longer the case. I'd just like to do
this.window.dispose() there. The patch file for the
change is attached, I'll probably just commit it but
you guys should review briefly.<br>
<br>
--Lee<br>
<br>
</div>
</div>
(snip)<br>
</blockquote>
</div>
</blockquote>
</div>
<br>
</blockquote>
<br>
</body>
</html>