Hi Johannes,<br><br>Great, thanks for this. Rick, please take a look at this code before beginning work on the imglib unit tests, as it looks like a good starting point.<br><br>-Curtis<br><br><div class="gmail_quote">On Wed, Apr 14, 2010 at 6:37 PM, Johannes Schindelin <span dir="ltr"><<a href="mailto:Johannes.Schindelin@gmx.de">Johannes.Schindelin@gmx.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi,<br>
<br>
On Thu, 15 Apr 2010, Stephan Saalfeld wrote:<br>
<br>
> Cursor.hasNext() == false does not mean that the cursor is out of image<br>
> bounds and, depending on the container may still point to some data.<br>
> Image keeping track of its cursors, it is good to close them for freeing<br>
> this data. Currently, this is important in cell containers only.<br>
><br>
> I think that the recent design changes regarding data access make this<br>
> tracking of cursors obsolete and so Cursor.close() too. A good hint is<br>
> that Image.removeCursor() is just never called. But I am very tired and<br>
> have to check this.<br>
<br>
Well, for the moment, I just played it safe. Please check out the<br>
junit-tests branch (based on master~2, so it will need adjusting once the<br>
huge changes of containerlevel come in).<br>
<br>
I know that I have to add a few comments, but I just spent almost 2 hours<br>
to hunt down a bug that I introduced in Fiji's javac 3 weeks ago, so I am<br>
thoroughly tired.<br>
<br>
The current version of the tests is here:<br>
<br>
<a href="http://pacific.mpi-cbg.de/cgi-bin/gitweb.cgi?p=imglib.git;a=commitdiff;h=fd8eb4b6a9ad62d4103d36017d9da7ff8f4fedae" target="_blank">http://pacific.mpi-cbg.de/cgi-bin/gitweb.cgi?p=imglib.git;a=commitdiff;h=fd8eb4b6a9ad62d4103d36017d9da7ff8f4fedae</a><br>
<br>
The idea is to have a few helper methods in TestBase which can<br>
<br>
- construct images algorithmically<br>
- compare images to some calculated values<br>
- compare "signatures", i.e. first and second order moments of intensity<br>
and coordinates.<br>
<br>
Obviously, I want to avoid large test images in the repository, and I want<br>
to make it very simple to add tests, because we need them.<br>
<br>
Ciao,<br>
Johannes<br>
<font color="#888888"><br>
--<br>
You received this message because you are subscribed to the Google Groups "Fiji-devel" group.<br>
To post to this group, send email to <a href="mailto:fiji-devel@googlegroups.com">fiji-devel@googlegroups.com</a>.<br>
To unsubscribe from this group, send email to <a href="mailto:fiji-devel%2Bunsubscribe@googlegroups.com">fiji-devel+unsubscribe@googlegroups.com</a>.<br>
For more options, visit this group at <a href="http://groups.google.com/group/fiji-devel?hl=en" target="_blank">http://groups.google.com/group/fiji-devel?hl=en</a>.<br>
<br>
</font></blockquote></div><br>